network: Fix metadata.xml results when old version is present#390
Merged
network: Fix metadata.xml results when old version is present#390
Conversation
Apply metadata.xml URL check results to the newest package version rather than the oldest, in order to fix displaying them when multiple package versions are available. Since the result objects are subclasses of FilteredVersionResult, they are filtered out when they do not apply to the newest version. Closes: #385
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
=======================================
Coverage 95.66% 95.66%
=======================================
Files 55 55
Lines 7543 7543
Branches 1838 1838
=======================================
Hits 7216 7216
Misses 203 203
Partials 124 124
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply metadata.xml URL check results to the newest package version
rather than the oldest, in order to fix displaying them when multiple
package versions are available. Since the result objects are subclasses
of FilteredVersionResult, they are filtered out when they do not apply
to the newest version.
Closes: #385